Update Gin as data source workflow #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested add - push - configure - push as a correct sequence. Addresses #779
I'm also in favor of leaving it as it is with your PR. Usually, it takes more time than anticipated for the release to happen, and we can fix or add to out of date instructions once they actually got out of date 👍 |
|
@all-contributors please add @mslw for content |
|
I've put up a pull request to add @mslw! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested add - push - configure - push as a correct sequence. Addresses part of #779 and datalad/datalad#6269
I verified the proposed workflow with DataLad version 0.15.3.
Now the question is what to do about upcoming changes in DataLad 0.16. The new release introduces
create-sibling-ginand shortens the workflow in question (git config --unset-all remote.gin.annex-ignoreshould be unnecessary whencreate-sibling-ginis used, see datalad/datalad#6230). I am in favour of keeping the current workflow (where the Gin repo is created manually) even after the release (as manual creation is not going away). Then, either add a separate example starting withcreate-sibling-gin, or note that thegit configstep can be skipped if the automated method was used. Should it be done in advance, or after DataLad 0.16 release?